This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Mon, 28 Jul 2014 09:58:53 +0200
- Subject: Re: [PATCH] Fix ICE with -Wodr (PR middle-end/61913)
- Authentication-results: sourceware.org; auth=none
- References: <20140727110235 dot GO30336 at redhat dot com>
On Sun, Jul 27, 2014 at 1:02 PM, Marek Polacek <polacek@redhat.com> wrote:
> Wodr in common.opt was missing a Var, which means:
> 1) we ICE with -Wodr, since -Wodr isn't handled in opts.c;
> 2) -Wno-odr wouldn't work.
> Thus fixed. I'd think this doesn't need a testcase...
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
Ok. Does this mean we don't have a -Wodr testcase?
Thanks,
Richard.
> 2014-07-27 Marek Polacek <polacek@redhat.com>
>
> PR middle-end/61913
> * common.opt (Wodr): Add Var.
>
> diff --git gcc/common.opt gcc/common.opt
> index a385ee0..3b04044 100644
> --- gcc/common.opt
> +++ gcc/common.opt
> @@ -588,7 +588,7 @@ Wmissing-noreturn
> Common Alias(Wsuggest-attribute=noreturn)
>
> Wodr
> -Common Warning
> +Common Var(warn_odr_violations) Warning
> Warn about some C++ One Definition Rule violations during link time optimization
>
> Woverflow
>
> Marek