This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, rs6000] Fix many powerpc*-linux ASAN test suite failures


On Fri, Jul 25, 2014 at 3:26 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> On Wed, 2014-07-23 at 15:06 -0500, Peter Bergner wrote:
>> On Wed, 2014-07-16 at 11:23 +0200, Jakub Jelinek wrote:
>> > On Wed, Jul 16, 2014 at 05:18:06AM -0400, David Edelsohn wrote:
>> > > This seems weird. Why wasn't this file included before or whenever it
>> > > was added for other *-linux targets?  This seems to define SPECs that
>> > > should have been necessary before now.
>> >
>> > All other Linux targets where asan is supported got the right definitions
>> > from gnu-user.h, it was needed even on the older release branches.
>>
>> Ok, I compiled a source file that #includes tm.h and looked at the -dD -E
>> output to see what macros get defined with and without this change.
>> There are a few macros the gnu-user.h defines that are identical to what
>> some of the rs6000/sysv4.h or rs6000/linux{,64}.h header files define, so
>> we could remove those.  There are some that are different too, so we'd
>> need to keep those.  The following are the macros that are identical:
>
> FYI, here is the mainline patch that removes the redundant macro defines
> in rs6000/linux.h and rs6000/linux64.h.  This also passed bootstrap and
> regtesting with no regressions.
>
>
> Peter
>
>
>         * config.gcc (powerpc*-*-linux*): Include gnu-user.h in tm_file.
>         * config/rs6000/sysv4.h (CC!_SPEC): Undefine it before defining it.
>         * config/rs6000/linux.h (CPLUSPLUS_CPP_SPEC): Delete define.
>         (LINK_GCC_C_SEQUENCE_SPEC): Likewise.
>         (USE_LD_AS_NEEDED): Likewise.
>         (ASM_APP_ON): Likewise.
>         (ASM_APP_OFF): Likewise.
>         (TARGET_POSIX_IO): Likewise.
>         * config/rs6000/linux64.h (CPLUSPLUS_CPP_SPEC): Likewise.
>         (LINK_GCC_C_SEQUENCE_SPEC): Likewise.
>         (USE_LD_AS_NEEDED): Likewise.
>         (ASM_APP_ON): Likewise.
>         (ASM_APP_OFF): Likewise.
>         (TARGET_POSIX_IO): Likewise.

Okay.

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]