This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][sched-deps] Generalise usage of macro fusion to work on any two insns


On Jul 24, 2014, at 10:11 AM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:

> Ping.
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00958.html
> 
> Kyrill
> 
> On 14/07/14 11:01, Kyrill Tkachov wrote:
>> On 11/07/14 14:20, Alexander Monakov wrote:
>>> On Fri, 11 Jul 2014, Kyrill Tkachov wrote:
>>>> On 10/07/14 22:53, Maxim Kuvyrkov wrote:
>>>>> The patch looks good to me, but some cleanup suggestions below.
>>>> Thanks, here's an updated patch.
>>>> How's this?
>>> You need to remove 'if (targetm. ...) SCHED_GROUP_P (insn) = 1;' from the
>>> first if branch, keeping only one SCHED_GROUP_P assignment at the end of the
>>> function.
>>> 
>>> Alexander
>> Thanks for the pointer, I had hurried a bit.
>> Here is the updated patch.
>> 

Hi Kyrill,

I have reviewed the latest version of your patch and it is perfectly fine with me.  You need to wait for an ack from the official maintainer to commit your patch.

Thank you,

--
Maxim Kuvyrkov
www.linaro.org

>> Kyrill
>> 
>> 2014-07-14  Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>              Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>> 
>>      * sched-deps.c (try_group_insn): Generalise macro fusion hook usage
>>      to any two insns.  Update comment.  Rename to sched_macro_fuse_insns.
>>      (sched_analyze_insn): Update use of try_group_insn to
>>      sched_macro_fuse_insns.
>>      * config/i386/i386.c (ix86_macro_fusion_pair_p): Reject 2nd arguments
>>      that are not conditional jumps.
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]