This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Implement N4051 - Allow typename in a template template parameter


On 22 July 2014 15:53, Ed Smith-Rowland <3dw4rd@verizon.net> wrote:
> On 07/22/2014 01:56 AM, Ville Voutilainen wrote:
>>
>> +/* Parse a type-parameter-key.
>> +
>> +   type-parameter-key:
>> +     class
>> +     typedef
>> +
>> +   Returns the kind of type-parameter-key specified, or none_type to
>> indicate
>> +   error.  */
>> +
>>
>> Typo above, should be typename, not typedef.
>>
> Thanks!
>
> New patch..
>
> OK?


Just my 2 cents - the test in the patch doesn't seem to test the error
diagnostics. The patch
amends some of those diagnostics, so I don't think existing tests cover those.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]