This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR55189 enable -Wreturn-type by default
- From: Sylvestre Ledru <sylvestre at debian dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Jason Merrill <jason at redhat dot com>
- Date: Sun, 20 Jul 2014 19:06:18 +0200
- Subject: Re: [Patch] PR55189 enable -Wreturn-type by default
- Authentication-results: sourceware.org; auth=none
- References: <538F7856 dot 1090104 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406042321130 dot 2874 at digraph dot polyomino dot org dot uk> <53903961 dot 9030501 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406051749260 dot 2819 at digraph dot polyomino dot org dot uk> <53A07226 dot 4040803 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406171712280 dot 23412 at digraph dot polyomino dot org dot uk> <53A07CCC dot 2030004 at debian dot org> <Pine dot LNX dot 4 dot 64 dot 1406171739550 dot 23412 at digraph dot polyomino dot org dot uk> <53BAD646 dot 7020102 at debian dot org>
Joseph, ping :)
(I know you were in holidays)
S
On 07/07/2014 19:17, Sylvestre Ledru wrote:
> Hello,
>
> On 17/06/2014 19:41, Joseph S. Myers wrote:
>> On Tue, 17 Jun 2014, Sylvestre Ledru wrote:
>>
>>> OK. I will do that.
>>> We should test the following:
>>> * default => run just -Wreturn-type
>>> * -Wreturn-type => Run both
>>> * -Wreturn-type + -Wmissing-return => Run both
>>> * -Wno-return-type + -Wmissing-return => Run just the second one
>>> * -Wno-return-type + -Wno-missing-return => Run none
>>> Do you see any other?
>> That looks like the right things to test, if there are no changes for
>> anything other than those options.
> Here it is:
> https://github.com/sylvestre/gcc/commit/db8aaac91aa09fd1ec1cc8974586aec45a221e71
>
> Is that what you expected?
>
>>> Besides that, are you OK with my changes? (with the tests updated)
>> The tests are key to reviewing whether the code changes actually do the
>> right thing.
> Right.
>
> Thanks again for your help and comments, it is really appreciated,
> Sylvestre
>