This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: symtab PATCH for c++/61623 (comdat issue in verify_symtab)
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 16 Jul 2014 13:02:30 +0200
- Subject: Re: symtab PATCH for c++/61623 (comdat issue in verify_symtab)
- Authentication-results: sourceware.org; auth=none
- References: <53C44915 dot 9080903 at redhat dot com> <20140715084639 dot GA10012 at kam dot mff dot cuni dot cz> <53C57D06 dot 4030703 at redhat dot com>
> On 07/15/2014 04:46 AM, Jan Hubicka wrote:
> >I think we still want to check that the local comdats are linked into
> >the corresponding comdat group, so we probably want
> >to test node->definition instead of node->public, or perhaps just clear
> >COMDAT_GROUP info when removing symbol?
>
> Like this?
>
>
> commit deb1a9e023d457c88edf52231d32af5ef03179f4
> Author: Jason Merrill <jason@redhat.com>
> Date: Mon Jul 14 16:58:57 2014 -0400
>
> PR c++/61623
> * symtab.c (symtab_remove_from_same_comdat_group): Also
> set_comdat_group to NULL_TREE.
> (verify_symtab): Fix diagnostic.
Yes, this looks perfect. Thanks a lot for looking into this!
Honza