This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, avr] Device macro correction for rev devices


S, Pitchumani schrieb:
Attached patch changes the device name macro of two rev devices, from REV
to rev in the name.

Device name macro:
__AVR_ATmega16HVBREVB__
__AVR_ATmega32HVBREVB__

Change to:
__AVR_ATmega16HVBrevB__
__AVR_ATmega32HVBrevB__

'rev' in small letters emphasizes the revision of the device.

This is *NOT* OK.

The built-in macros for these devices have been uppercase in avr-gcc and AVR-Libc aver since, and they have always be compatible.

Just because one vendor (Atmel) lost track of their patches is no reason to introduce changes that render tools incompatible with existing code or with bit older versions of AVR-Libc or GCC.

BTW; the same change has been rejected for AVR-Libc for the same reason:

http://savannah.nongnu.org/bugs/?42696

Johann




Regards,
Pitchumani

gcc/ChangeLog

2014-07-14  Pitchumani Sivanupandi  <pitchumani.s@atmel.com>

    * config/avr/avr-mcus.def (atmega16hvbrevb): Change device name macro
    to __AVR_ATmega16HVBrevB__.
    (atmega32hvbrevb): Change device name macro to __AVR_ATmega32HVBrevB__.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]