This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: More informative ODR warnings


> Hi Honzo,
Nazdar Geralde,
> 
> On Sun, 13 Jul 2014, Jan Hubicka wrote:
> > +@opindex Wodr
> > +@opindex Wno-odr
> > +@opindex Wodr
> > +Warn about One Definition Rule violations during link time optimization.
> > +Require @option{-flto-odr-type-merging} to be enabled. Enabled by default
> 
> here in invoke.texi you talk about One Definition Rule violations
> (which might imply all) whereas...
> 
> > +Wodr 
> > +Common Warning 
> > +Warn about some C++ One Definition Rule violations during link time optimization
> 
> ...here you note that it's "some" and add C++.
> 
> Should these two restrictions be noted in invoke.texi as well?

Actually the first hunk (in invoke.texi) is a version that is correct only with my
ODR streaming patch that may or may not land mainline.  I will update it to the simplified
version from common.opt. Basically we now warn only on ODR violations within polymorphic
types.

Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]