This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook


> 
> -  if (!TARGET_VFP)
> -    return;
> +  if (!TARGET_VFP || TARGET_THUMB1)
> +    return default_atomic_assign_expand_fenv (hold, clear, update);
> 
> You don't need to call default function here. It is empty, the
> documentation says:
> 
> "The default implementation leaves all three expressions as @code{NULL_TREE}."
> 
> Also, the function is declared as void, so returning something looks
> strange to me.

Thanks for the comment. Here is a patch to change this. There was also a
comment from Jay with respect to a cut and paste error that might
confuse the readers. I am fixing that as well.

regression tested on qemu for arm-none-linux-gnueabi with no new
regressions.

Please let me know if this is OK?

Thanks,
Kugan

gcc/
2014-057-12  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* config/arm/arm.c (bdesc_2arg): Fix typo.
	(arm_atomic_assign_expand_fenv): Remove The default implementation.

Attachment: fenv.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]