This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 11 Jul 2014 15:42:01 +0200
- Subject: Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1406121206150 dot 32404 at zhemvz dot fhfr dot qr> <539A0E6B dot 3080905 at redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1406271317130 dot 29270 at zhemvz dot fhfr dot qr> <20140627115658 dot GB31640 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1406271355010 dot 29270 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1407101627200 dot 5753 at zhemvz dot fhfr dot qr> <20140710151259 dot GL31640 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1407111000040 dot 5753 at zhemvz dot fhfr dot qr> <alpine dot LSU dot 2 dot 11 dot 1407111535370 dot 5753 at zhemvz dot fhfr dot qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 11, 2014 at 03:36:15PM +0200, Richard Biener wrote:
> *************** c_strlen (tree src, int only_value)
> *** 606,612 ****
>
> /* If the offset is known to be out of bounds, warn, and call strlen at
> runtime. */
> ! if (offset < 0 || offset > max)
> {
> /* Suppress multiple warnings for propagated constant strings. */
> if (! TREE_NO_WARNING (src))
> --- 610,617 ----
>
> /* If the offset is known to be out of bounds, warn, and call strlen at
> runtime. */
> ! if (only_value != 2
> ! && (offset < 0 || offset > max))
> {
> /* Suppress multiple warnings for propagated constant strings. */
> if (! TREE_NO_WARNING (src))
This looks wrong. I'd say you only want to disable the warning for
only_value != 2, but still return NULL_TREE, otherwise the strlen call will
be out of bounds in the compiler. So move only_value != 2 down to the
second if ?
Jakub