This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] java: Use build_qualified_type instead of build_type_variant.
- From: Mark Wielaard <mjw at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, GCJ-patches <java-patches at gcc dot gnu dot org>, Tom Tromey <tromey at redhat dot com>
- Date: Wed, 09 Jul 2014 12:57:59 +0200
- Subject: Re: [PATCH] java: Use build_qualified_type instead of build_type_variant.
- Authentication-results: sourceware.org; auth=none
- References: <1404850329-16974-1-git-send-email-mjw at redhat dot com> <CAFiYyc0TRtcSN53U=Pd5B338YDbq1LodWwGunZ=V-9AH+U7jxw at mail dot gmail dot com>
On Wed, 2014-07-09 at 12:23 +0200, Richard Biener wrote:
> On Tue, Jul 8, 2014 at 10:12 PM, Mark Wielaard <firstname.lastname@example.org> wrote:
> > The java frontend is one of the only places where build_type_variant is
> > still used. New code should use build_qualified_type. See gcc/tree.h.
> > Build and tested on x86_64-unknown-linux-gnu.
> Can build_type_variant be removed now?
Not yet. There are still a few usages that are easy to change to
build_qualified_type like the ones in the java frontend.
But there are 3 cases that I haven't figured out yet. c-common, ada and
lto all use it in their implementation of handle_noreturn_attribute and
c-common and lto in handle_const_attribute. I think the c-common one is
correct, but maybe there is a reason for them to be slightly different.