This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR61459 - [4.8/4.9/4.10 Regression] segfault when assigning to allocatable function result from matmul result
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>
- Date: Mon, 7 Jul 2014 11:22:29 +0200
- Subject: Re: [Patch, fortran] PR61459 - [4.8/4.9/4.10 Regression] segfault when assigning to allocatable function result from matmul result
- Authentication-results: sourceware.org; auth=none
- References: <20140707080544 dot GA1060 at physik dot fu-berlin dot de>
Dear Tobias,
The patch is so safe and, as you say, has no side effects that I will
commit to 4.9 first.
Cheers
Paul
On 7 July 2014 10:05, Tobias Burnus <tobias.burnus@physik.fu-berlin.de> wrote:
> Paul Richard Thomas wrote:
>> This PR is caused by a rather unfortunate cast for the pointer to the
>> return value from matmul:
> [...]
>> The fix is obvious (ie use its natural kind)
> [...]
>> Dominique points out that the patch fixes PR58883 as well. I'll
>> enhance the testcase appropriately.
>
> Nice!
>
>> Unless anybody has any objections, I'll commit to trunk tonight and to
>> 4.8 and 4.9 next weekend.
>
> Looks good to me. As the patch shouldn't have side effects and as Jakub
> intents to do a 4.9.1 RC early this week, I'd prefer it the 4.9 patch
> would be committed earlier.
>
> Tobias
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy