This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.


On Mon, Jun 30, 2014 at 5:54 PM, Richard Henderson <rth@redhat.com> wrote:
> On 06/29/2014 11:14 AM, Uros Bizjak wrote:
>>    if (MEM_READONLY_P (x))
>> +    if (GET_CODE (mem_addr) == AND)
>> +      return 1;
>>      return 0;
>
> Certainly missing braces here.  But with that fixed the patch looks plausible.
>  I'll look at it closer later today.

Umm... but certainly a very gross hack for a special target in a very
general routine.

So - please no!

If addresses with AND are supposed to be barriers then you should
model this explicitely in the IL and not make it work "magically".
Maybe use ALIAS_SET_MEMORY_BARRIER instead?

Richard.

>
> r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]