This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Implement -fsanitize=bounds and internal calls in FEs


On Thu, Jul 03, 2014 at 12:46:35PM +0200, Jakub Jelinek wrote:
> On Thu, Jul 03, 2014 at 12:41:46PM +0200, Marek Polacek wrote:
> > On Sat, Jun 28, 2014 at 06:52:00PM +0200, Gerald Pfeifer wrote:
> > > On Fri, 20 Jun 2014, Marek Polacek wrote:
> > > +@item -fsanitize=bounds
> > > +@opindex fsanitize=bounds
> > > +
> > > +This option enables instrumentation of array bounds.  Various out of bounds
> > > +accesses are detected.  Flexible array members are not instrumented, as well
> > > +as initializers of variables with static storage.
> > > 
> > > Can you make this "Flexible array members and initializers..." (or
> > > "...as well as...")?  The current wording confused me a bit at first.
> > > 
> > > And I believe there should be no empty line after @opindex.
> > 
> > Thanks, I'll fix both with the following.  Also
> > -fsanitize=float-divide-by-zero and -fsanitize=float-cast-overflow
> > descriptions were at a wrong place, so moved a little bit above.
> > 
> > Applying to trunk as obvious.
> > 
> > 2014-07-03  Marek Polacek  <polacek@redhat.com>
> > 
> > 	* doc/invoke.texi (-fsanitize=bounds): Tweak wording.
> > 	(-fsanitize=float-divide-by-zero): Move to the table with
> > 	-fsanitize=undefined suboptions.
> > 	(-fsanitize=float-cast-overflow): Likewise.
> 
> Those two aren't -fsanitize=undefined suboptions, so shouldn't be included
> in there.

But they're parts of ubsan and at least
-fsanitize=float-divide-by-zero says it is not enabled by
-fsanitize=undefined.  Dunno, I can move it back if you want.

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]