This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Honor the vxworks options overrides on VxWorksae


With the patch attached ...

On Jun 30, 2014, at 15:29 , Olivier Hainque <hainque@adacore.com> wrote:

> Hello,
> 
> The vxworks_override_option code is general enough to apply to both regular
> VxWorks and VxWorksAE configurations.
> 
> The VxWorksAE configuration files miss the triggering bits, however, with
> various kinds of consequences. One example is -fPIC being accepted without
> -mrtp, while it should be rejected by
> 
>   vxworks_override_options()
>   {
>     ...
>     /* PIC is only supported for RTPs.  */
>     if (flag_pic && !TARGET_VXWORKS_RTP)
>        error ("PIC is only supported for RTPs");
> 
> 
> The attached patch fixes this by defining VXWORKS_OVERRIDE_OPTIONS for AE as
> for the regular vxworks targets.
> 
> Tested by verifying that the port still builds after the change, and
> that -fPIC without -mrtp is rejected as it should.
> 
> OK to commit ?
> 
> Thanks in advance,
> 
> With Kind Regards
> 
> 2014-05-30  Olivier Hainque  <hainque@adacore.com>
> 
> 	* config/vxworksae.h (VXWORKS_OVERRIDE_OPTIONS): Define.
> 

Attachment: vxae-override.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]