This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, libgomp]: Require vect_simd_clones effective target for libgomp.fortran/declare-simd-[12].f90


On Tue, May 27, 2014 at 08:58:18AM +0200, Uros Bizjak wrote:
> These tests require vect_simd_clones effective target, as the target
> should be able to compile AVX clones.
> 
> 2014-05-27  Uros Bizjak  <ubizjak@gmail.com>
> 
>     * testsuite/libgomp.fortran/declare-simd-1.f90: Require
>     vect_simd_clones effective target.  Remove
>     dg-additional-options directives.
>     * testsuite/libgomp.fortran/declare-simd-2.f90: Ditto.
> 
> Tested on x86_64-linux-gnu CentOS 5.

Please don't remove the dg-additional-options there, that is completely
intentional there, only the simd clones are built for SSE2/AVX/AVX2,
the simd loops are built with whatever options the loop is compiled with,
and for the common case (AVX or later HW, but compiler not configured to
support only AVX or later) I want to test as much vectorization as possible.
Requiring vect_simd_clone or the whitespace change is fine, though I'd
just use ! { dg-do run { target vect_simd_clones } } instead of
dg-require-effective-target.

> Index: testsuite/libgomp.fortran/declare-simd-1.f90
> ===================================================================
> --- testsuite/libgomp.fortran/declare-simd-1.f90	(revision 210956)
> +++ testsuite/libgomp.fortran/declare-simd-1.f90	(working copy)
> @@ -1,6 +1,5 @@
>  ! { dg-options "-fno-inline" }
> -! { dg-additional-options "-msse2" { target sse2_runtime } }
> -! { dg-additional-options "-mavx" { target avx_runtime } }
> +! { dg-require-effective-target vect_simd_clones }
>  
>  module declare_simd_1_mod
>    contains
> Index: testsuite/libgomp.fortran/declare-simd-2.f90
> ===================================================================
> --- testsuite/libgomp.fortran/declare-simd-2.f90	(revision 210956)
> +++ testsuite/libgomp.fortran/declare-simd-2.f90	(working copy)
> @@ -1,8 +1,7 @@
>  ! { dg-do run }
>  ! { dg-options "-fno-inline" }
> -  ! { dg-additional-sources declare-simd-3.f90 }
> -! { dg-additional-options "-msse2" { target sse2_runtime } }
> -! { dg-additional-options "-mavx" { target avx_runtime } }
> +! { dg-additional-sources declare-simd-3.f90 }
> +! { dg-require-effective-target vect_simd_clones }
>  
>  module declare_simd_2_mod
>    contains


	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]