This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR54733 Optimize endian independent load/store


On 23 May 2014 05:36, Thomas Preud'homme <thomas.preudhomme@arm.com> wrote:
>> From: Richard Biener [mailto:richard.guenther@gmail.com]
>> On Wed, May 21, 2014 at 3:00 AM, Thomas Preud'homme
>> <thomas.preudhomme@arm.com> wrote:
>
>> >
>> > Updated ChangeLogs:
>> >
>> > *** gcc/ChangeLog ***
>> >
>> > 2014-05-20  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>> >
>> >         PR tree-optimization/54733
>> >         * tree-ssa-math-opts.c (nop_stats): New "bswap_stats" structure.
>> >         (CMPNOP): Define.
>> >         (find_bswap_or_nop_load): New.
>> >         (find_bswap_1): Renamed to ...
>> >         (find_bswap_or_nop_1): This. Also add support for memory source.
>> >         (find_bswap): Renamed to ...
>> >         (find_bswap_or_nop): This. Also add support for memory source and
>> >         detection of bitwise operations equivalent to load in host endianness.
>> >         (execute_optimize_bswap): Likewise. Also move its leading comment
>> back
>> >         in place and split statement transformation into ...
>> >         (bswap_replace): This.
>> >
>> > *** gcc/testsuite/ChangeLog ***
>> >
>> > 2014-05-20  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>> >
>> >         PR tree-optimization/54733
>> >         * gcc.dg/optimize-bswapdi-3.c: New test to check extension of bswap
>> >         optimization to support memory sources and bitwise operations
>> >         equivalent to load in host endianness.
>> >         * gcc.dg/optimize-bswaphi-1.c: Likewise.
>> >         * gcc.dg/optimize-bswapsi-2.c: Likewise.
>> >         * gcc.c-torture/execute/bswap-2.c: Likewise.
>> >
>> > Best regards,
>>
>> This is ok.
>
> Great. Commited.
>
> Thanks a lot for your patience in mentoring me to improve this patch.
>
> Best regards,
>
> Thomas
>

I have noticed that the new bswap-2.c test fails at execution on armeb targets.
See:
http://cbuild.validation.linaro.org/build/cross-validation/gcc/210843/report-build-info.html

Could you have a look?
Thanks,

Christophe.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]