This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9


> The build went fine. Is something still missing?

We never keep commented out code, except with a ??? comment explaining why.
We don't use 'FIXME', we use ??? instead.

Also, some of the comments seem to be copy/paste from freebsd, which is
likely not appropriate for GNU Hurd, so need to be revised.

The header is wrong: it should be GPLv3+, not GPLv2+

Also:

> +   --  1_024 == 1024??

Remove this comment. Yes, 1_024 is the same as 1024 in Ada.

Arno


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]