This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Enable Java on Cygwin-64
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "java-patches at gcc dot gnu dot org" <java-patches at gcc dot gnu dot org>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Date: Mon, 12 May 2014 18:07:25 +0200
- Subject: Re: [PATCH] Enable Java on Cygwin-64
- Authentication-results: sourceware.org; auth=none
- References: <DUB118-W36635B73214FEBB0B9CA0BE44A0 at phx dot gbl>
Hi,
I have the following comment.
boehm-gc/ChangeLog:
2014-05-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
Fix current cygwin-64 build problems.
* include/gc_config_macros.h (GC_PTHREADS): Use __CYGWIN__ instead
of __CYGWIN32__ here.
* win32_threads.c (GC_push_all_stacks): Push all X86_64 registers.
(GC_get_thread_stack_base): Get the stack base for X86_64.
That change is ok. Please don't miss to post the changes also to boehm-gc's ML.
In general it is better to splitt patches into seprate patches. To
put all in one isn't ease review here.
libffi/ChangeLog:
2014-05-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
Fix current cygwin-64 build problems.
* src/java_raw_api.c: Remove if !defined(FFI_NO_RAW_API).
* src/x86/ffi.c: Add if defined(__CYGWIN__).
* src/x86/win64.S (ffi_closure_win64, ffi_call_win64): Added
handling for FFI_TYPE_UINT64, FFI_TYPE_POINTER and FFI_TYPE_INT.
Added SEH information. Fixed formatting.
Patch is ok IMO. Nevertheless this part shall go also to libffi's ML.
libgcc/ChangeLog:
2014-05-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
* unwind-seh.c (_Unwind_Backtrace): Uncommented, finished
implementation.
This part of the patch is ok. Please apply to trunk.
libjava/ChangeLog:
2014-05-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
Fix current cygwin-64 build problems.
* configure.host: Added handling for x86_64-*-cygwin/mingw.
* boehm.cc (_Jv_GCAttachThread, _Jv_GCDetachThread): Don't compile if
GC_WIN32_THREADS is defined.
* java/lang/natClass.cc (_Jv_InterfaceAssignableFrom): Rename interface
to source_interface.
This part of the patch looks ok too. As here a libjava-maintainer
needs to look into too, you should post this part again to ML with
prominent marking libjava in subject line.
libjava/classpath/ChangeLog:
2014-05-11 Bernd Edlinger <bernd.edlinger@hotmail.de>
Fix current cygwin-64 build problems.
* native/fdlibm/mprec.c (_REENT_CHECK_MP, _REENT_MP_FREELIST,
_REENT_MP_P5S, __ULong, __Long): Undefine previous definitions.
Same here. Looks ok to me, too. Nevertheless please post it as
separate thread to ML.
Thanks,
Kai