This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C PATCH] Make attributes accept enum values (PR c/50459)


On Sun, 11 May 2014, Marek Polacek wrote:

> > FAIL: c-c++-common/pr50459.c -std=gnu++1y (test for excess errors)
> > FAIL: c-c++-common/pr50459.c  -Wc++-compat  (test for excess errors)
> > 
> > The errors are
> > 
> > /opt/gcc/work/gcc/testsuite/c-c++-common/pr50459.c:8:1: error: constructor priorities are not supported
> > /opt/gcc/work/gcc/testsuite/c-c++-common/pr50459.c:9:1: error: destructor priorities are not supported
> 
> Ah.  The following untested patch should skip that test on Darwin.
> 
> Ok?

I don't think the whole test should be skipped for that issue; I think the 
part requiring this feature should be split out into a separate testcase, 
so that as much as possible is still tested on Darwin.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]