This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call


Hi Wei,

please teach your mailer not to break/mangle long lines.  Thanks.

> Here is a patch for the test. It contains two changes:
> 1. For emutls, there will be an explicit call generated at expand
> pass, and no stack adjustment is needed. So add /* {
> dg-require-effective-target tls_native } */ in the test.
> 2. Replace cfi_def_cfa_offset with insn sequence check.
>
> Is it ok?

No, the test FAILs for 32-bit i386-pc-solaris2.11 with Sun as/ld:

FAIL: gcc.target/i386/pr58066.c scan-assembler sub[^\r\n]*8[^\r\n]*sp.*call[^\r\n]*__tls_get_addr.*sub[^\r\n]*8[^\r\n]*sp.*call[^\r\n]*__tls_get_addr

The TLS code sequence is different here:

        subl    $8, %esp
        leal    ccc1@tlsgd(,%ebx,1), %eax
        call    ccc1@tlsgdplt

I fear this insn scanning is going to be extremely fragile.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]