This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Make attributes accept enum values (PR c/50459)
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Dominique Dhumieres <dominiq at lps dot ens dot fr>, gcc-patches at gcc dot gnu dot org, iains at gcc dot gnu dot org, joseph at codesourcery dot com
- Date: Mon, 12 May 2014 16:40:59 +0200
- Subject: Re: [C PATCH] Make attributes accept enum values (PR c/50459)
- Authentication-results: sourceware.org; auth=none
- References: <20140510141047 dot 3D98C103 at mailhost dot lps dot ens dot fr> <20140511180141 dot GD23554 at redhat dot com> <yddvbtc15uw dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <20140511195919 dot GE23554 at redhat dot com>
Marek Polacek <polacek@redhat.com> writes:
> On Sun, May 11, 2014 at 09:18:47PM +0200, Rainer Orth wrote:
>> No, that's wrong: avoid hardcoding target lists if at all possible.
>> Besides, it's wrong since it doesn't cover the Solaris (and other
>> non-gld linker) case. Use the init_priority effective-target keyword
>> instead. Also, please check if you can use dg-xfail-if instead: if
>> anything changes, the test turns into an XPASS instead of the change
>> going unnoticed with dg-skip-if.
>
> I don't see tests using dg-skip-if and init_priority, so this patch
No need for examples: as you can see in doc/sourcebuild.texi, both dg-do
and dg-skip-if accept the same selectors.
> does what we do for other tests using cdtor priorities.
>
> 2014-05-11 Marek Polacek <polacek@redhat.com>
>
> * c-c++-common/pr50459.c: Require init_priority target.
Ok.
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University