This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)


On 04/28/2014 10:08 AM, Christian Bruel wrote:
>>>> Hello,
>>>>
>>>> I'd like to ping the following patches
>>>>
>>>> [Hookize mode-switching]
>>>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01003.html
>>>>
>>>> [Add new hooks to support toggle and SH4A fpchg instruction]
>>>> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01005.html
> Sorry, I only saw the first part and thought I' d need to wait till I
> see the second part - and I somehow missed that.
>
> I think the previous known mode should be passed to the
> TARGET_MODE_EMIT hook - no need to have extra hooks
> for toggling, and, as I mentioned earlier, fixating on the toggle is
> actually an SH artifact - other ports have multi-way
> modes settings that can benefit from knowing the previous mode.

OK I'll change the bool toggle parameter by the previous mode in
TARGET_MODE_EMIT and remove the bool XOR hooks in the SH description.
Just for my curiosity, which other targets have multi-way toggling
support ?

I'll commit the first patch as approved and re post the second one.

Many thanks,

Christian



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]