This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header
- From: Michael Matz <matz at suse dot de>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 May 2014 12:32:39 +0200 (CEST)
- Subject: Re: [PATCH 7/7] Move SYMBOL_REF_FLAGS to rtx header
- Authentication-results: sourceware.org; auth=none
- References: <87a9ap1k8n dot fsf at talisman dot default> <87fvkhz8js dot fsf at talisman dot default>
On Sat, 10 May 2014, Richard Sandiford wrote:
> @@ -362,6 +362,9 @@ struct GTY((chain_next ("RTX_NEXT (&%h)"
> /* The INSN_UID of an RTX_INSN-class code. */
> int insn_uid;
> + /* The SYMBOL_REF_FLAGS of a SYMBOL_REF. */
> + unsigned int symbol_ref_flags;
In [3/7] you used
+ /* The ORIGINAL_REGNO of a REG. */
+ unsigned original_regno;
Should be consistent. Also I'm idly wondering if the explicit sizing of
the fields via a bit-field as originally would be better here or just
confusing. I guess unsigned and enums are 32bit for all hosts we care
about, but if we ever have one where it's larger the rtx will suddenly
contain another hole.