This is the mail archive of the
mailing list for the GCC project.
Re: [GSoC] use obstack in parse_c_expr
- From: Jeff Law <law at redhat dot com>
- To: Prathamesh Kulkarni <bilbotheelffriend at gmail dot com>, Diego Novillo <dnovillo at google dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 09 May 2014 14:30:33 -0600
- Subject: Re: [GSoC] use obstack in parse_c_expr
- Authentication-results: sourceware.org; auth=none
- References: <CAJXstsA7X8JQEdiyWtCaO95RO=pFdbBfS8DT5q-qyG7GjZqhZw at mail dot gmail dot com> <CAD_=9DTCs4N+9=6WZ1veh5WdUzjWJBKtRc0uaauAX_2RJ_zB=w at mail dot gmail dot com> <CAJXstsBGmsAk8s6MLkg_UgqGmrmXn4=W6uqhC7mLPvGF+J1epw at mail dot gmail dot com>
On 04/25/14 05:39, Prathamesh Kulkarni wrote:
On Thu, Apr 24, 2014 at 9:18 PM, Diego Novillo <email@example.com> wrote:
Please remember to send patches to gcc-patches.
I'm wondering if you couldn't just use std::string here. No need to change
one complicated allocation scheme with another.
Since we were using c-styled strings throughout genmatch, I thought of
using obstack instead of std::string.
This patch uses std::string in parse_c_expr to build c-code string.
Should we also change AST (operand and subclasses) to use std::string
instead of c-styled strings ?
Yes, let's go with this.