This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Clean up and extend VRP edge-assertion code
- From: Patrick Palka <patrick at parcs dot ath dot cx>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 5 May 2014 09:01:11 -0400
- Subject: Re: [PATCH] Clean up and extend VRP edge-assertion code
- Authentication-results: sourceware.org; auth=none
- References: <1399146940-29802-1-git-send-email-patrick at parcs dot ath dot cx> <CA+C-WL-wDyWZ16RBVubOBew8JcAi+5WqokG8Q7buQhgodtjJ3g at mail dot gmail dot com> <CA+C-WL97XboTXmiAZEoph-PYS3TPBMMJ9uWqMvHLCVqsWZbr3A at mail dot gmail dot com> <CAFiYyc09EBCrOsF8R_X1Py6pw4tx0zdRXZp_tnTpQaRJmyMAYw at mail dot gmail dot com>
On Mon, May 5, 2014 at 8:47 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Mon, May 5, 2014 at 4:45 AM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>> On Sun, May 4, 2014 at 12:20 PM, Patrick Palka <patrick@parcs.ath.cx> wrote:
>>> This patch causes a latent test failure in gcc.dg/uninit-pred-9_b.c
>>> due to an oversight in the tree-ssa-uninit code for which I will send
>>> a fix shortly.
>>
>> Never mind, I spoke too soon.. I haven't been able to solve this properly.
>
> It would be good to split the refactoring from extending the functionality.
> Also each of the cases you add should be accompanied by a testcase.
>
> Thanks,
> Richard.
Ok, will do.