This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path


On 05/04/14 00:39, bin.cheng wrote:>
Hi,
I updated and rebased the patch against latest trunk.  It passes bootstrap
and regression test on x86/x86_64.   Also pr60363 is fixed on
logical_op_short_circuit targets.  Is it OK?

Since ssa-dom-thread-4.c is fixed now, I also reverted the XFAIL test for
it.
Yes.  This is fine.  Please install.



An irrelevant point, the const propagation opportunities exist not only for
threaded jump path, but also for the original path after threading jump.  So
maybe it's worth to do the general transformation as Jeff suggested before.
Most of the time, const propagation opportunities on the original path are limited to PHIs that become degenerate as a result of isolation of the threaded path. We use a specialized propagator which seeds strictly from PHIs to catch those.

If you've got testcases where there's const propagation opportunities on the original path that do not originate from PHIs that become degenerate as a result of threading, certainly file a BZ so we can all take a look.


thanks,
Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]