This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C PATCH] remove goto in c_parser_sizeof_expression


On 04/25/14 01:18, Marek Polacek wrote:
On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote:
On 02/24/14 12:28, Marek Polacek wrote:
On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote:
Replaced tab by 4 spaces before error_at.
* c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr.

Looks good now, but I can't approve it.  Thanks,
Applied to the trunk.  Thanks and sorry for the delays.

Hold on, I thought that in the end we don't want this.  I wanted to
point out formatting issues, and it seemed good to go, but after
Joseph's mail I have changed my mind; goto seems clearer here (to me).
Sorry, I didn't see Joseph's mail.  I'll revert.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]