Re: [Patch, Fortran] Fix an issue with CLASS and -fcoarray=lib on the trunk

[Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>]

Dear Tobias,

On 27 April 2014 20:56, Tobias Burnus <burnus@net-b.de> wrote:
> First, I would be really delighted if someone could review my coarray
> patches for the trunk as it makes simpler to develop patches on top of it:
> * http://gcc.gnu.org/ml/fortran/2014-04/msg00087.html

This is OK for trunk.

> * http://gcc.gnu.org/ml/fortran/2014-04/msg00091.html

"dg2final" ???? Surely this is a typo?  Although I note that getting
it wrong on a German keyboard should produce a 4. Therefore it might
well be a command that i do not know about.

Otherwise, OK for trunk.

> * http://gcc.gnu.org/ml/fortran/2014-04/msg00092.html
>

This is OK for trunk

> Secondly, attached is a patch which fixes an ICE - and prepares for some
> additional class-related coarray patches. In particular, the patch ensures
> that for nonallocatable *polymorphic* coarrays, the coarray token and offset
> are passed.

This is also OK for trunk.
>
> Build and regtested on x86-64-gnu-linux.
> OK for the trunk?
>
> Tobias
>
> PS: There is still something wrong (for both -fcoarray=single and
> -fcoarray=lib) with lcobound/ucobounds and polymorphic coarrays and with
> using them with select type and associated. That's something I would like to
> tackle next. If that's done, I probably should really concentrate on
> reviewing a few patches and doing some other bug fixes before continue
> working on coarrays.

Thank you truly for the effort that you are putting into co-arrays.
It is highly gratifying that gfortran seems to perform so well
compared with another product.  Frankly, if I were you I would
continue working on co-arrays, whilst you have the wind in your sails
:-)

Best regards

Paul



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy