This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC] Remove PUSH_ARGS_REVERSED from the RTL expander.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: Jeff Law <law at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, James Greenhalgh <James dot Greenhalgh at arm dot com>, "richard dot guenther at gmail dot com" <richard dot guenther at gmail dot com>
- Date: Tue, 29 Apr 2014 11:04:42 +0100
- Subject: Re: [RFC] Remove PUSH_ARGS_REVERSED from the RTL expander.
- Authentication-results: sourceware.org; auth=none
- References: <1395661485-28060-1-git-send-email-james dot greenhalgh at arm dot com> <535AC27D dot 2080808 at redhat dot com> <2334797 dot e1Lr9971XM at polaris>
On 26/04/14 14:25, Eric Botcazou wrote:
>>> 2014-03-21 James Greenhalgh <james.greenhalgh@arm.com>
>>>
>>> * calls.c (initialize_argument_information): Always treat
>>> PUSH_ARGS_REVERSED as 1, simplify code accordingly.
>>> (expand_call): Likewise.
>>> (emit_library_call_calue_1): Likewise.
>>> * expr.c (PUSH_ARGS_REVERSED): Do not define.
>>> (emit_push_insn): Always treat PUSH_ARGS_REVERSED as 1, simplify
>>> code accordingly.
>>
>> This is fine for the trunk at this point.
>
> Are you sure that it's not a correctness issue for some targets though?
>
Ordering of side-effects these days are handled during gimplification.
If there are any correctness issues relating to this, then I think we've
got a bigger problem.
R.