This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Kai Tietz <ktietz at redhat dot com>, Ray Donnelly <mingw dot android at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Kai Tietz <ktietz70 at gmail dot com>
- Date: Fri, 25 Apr 2014 21:05:20 +0200
- Subject: Re: [PATCH 2/2] Windows libcpp: Make path-exists semantics more Posix-like
- Authentication-results: sourceware.org; auth=none
- References: <1397936424-2290-1-git-send-email-mingw dot android at gmail dot com> <1397936424-2290-3-git-send-email-mingw dot android at gmail dot com> <1034557352 dot 9542218 dot 1397940098399 dot JavaMail dot zimbra at redhat dot com> <535A92FD dot 5080009 at redhat dot com>
2014-04-25 18:53 GMT+02:00 Pedro Alves <palves@redhat.com>:
> On 04/19/2014 09:41 PM, Kai Tietz wrote:
>
>> Isn't this function something better placed in libiberty? Also this name looks a bit confusing. Wouldn't be a an function calling for _WIN32 case also stat, and just overrides the st_mode member, if it is a link better. So I would put this function to the file_... API of libiberty.
>
> I'd even suspect that e.g., GNU Make / Makefiles would be likewise affected
> by this. A solution for this in gcc, or in a few selected programs
> only, looks brittle to me. Perhaps it should be mingw itself that provides
> a _non-default_ replacement as option (similarly to __mingw_printf).
Of course we could change default-behavior of stat-function within
mingw. This would change documented and exprected behavior of
msvcrt's implementation. And all this for an assumption made by some
ventures.
I think that libiberty is exactly present to unify functionality (and
API) for different operation systems. Exactly for this libiberty was
made, isn't it?
I agree that there are other venture, which might be affected by same
problem. So those venture could either use libiberty to solve this
problem too, or need to reimplement it as they do now.
> Can't glibc be changed to not rely on this? /me hides.
>
> --
> Pedro Alves
Kai