This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope
- From: Mike Stump <mikestump at comcast dot net>
- To: Dimitris Papavasiliou <dpapavas at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 24 Apr 2014 18:07:02 -0700
- Subject: Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope
- Authentication-results: sourceware.org; auth=none
- References: <52F35508 dot 4080205 at gmail dot com> <5486E33D-B8F6-473F-8F33-6A7DEECB45A8 at comcast dot net> <5359999C dot 7090607 at gmail dot com>
On Apr 24, 2014, at 4:09 PM, Dimitris Papavasiliou <dpapavas@gmail.com> wrote:
> On 04/24/2014 07:00 PM, Mike Stump wrote:
>> On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou <dpapavas@gmail.com> wrote:
>>> This is a patch regarding a couple of Objective-C related dialect options and warning switches.
>>
>> Ok.
>>
>> Committed revision 209753.
>>
>> If you could, please add documentation and a test case.
>
> Thanks for taking the time to look at this, although to be honest I didn't expect a straight merge into the trunk.
Don’t submit changes you don’t want! :-)
> I'll add documentation and test cases as soon as I figure out how.
Just copy testsuite/objc.dg/private-2.m into shadow-1.m and then `fix’ it to test what you want. If you need one with and one without a flag, copy it twice and use something like:
// { dg-options "-Wshadow" }
on it. Type make RUNTESTFLAGS=dg.exp=shadow-1.m check-objc to test it.
For the doc, just find a simple option in the part of the manual you want to put it in, and copy it. We document the non-default, (Wno-shadow-ivar for example) options.