This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Fix a bug of consecutive range quantifiers in regex
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 24 Apr 2014 11:56:21 +0100
- Subject: Re: [Patch] Fix a bug of consecutive range quantifiers in regex
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDm5-hujsBT7VwyZ3LipuujXCJvMO-079zdtaNaehZA-XQ at mail dot gmail dot com> <CAPrifDnSRJZcNeoB72hOYYaniuTMBZfYosGi60uWF50xgozHMg at mail dot gmail dot com>
On 24 April 2014 04:47, Tim Shen wrote:
>> Booted and tested with -m32 and -m64.
>
> I should give an explanation:
>
> When traversing a graph in _M_clone(), it should stop at a node with
> id _M_end. However, if _M_end has other outgoing edge (_M_alt), the
> edge should be concerned too. So this patch move the _M_alt part
> before the _M_end test, thus _M_alt must be traversed.
Unless I'm doing something wrong the new tests you added already give
the right results, do you have a testcase that fails with the current
code?