This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC][wide-int] Fix some build errors on arm in wide-int branch and report ICE
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, "mikestump\ at comcast dot net" <mikestump at comcast dot net>, "zadeck\ at naturalbridge dot com" <zadeck at naturalbridge dot com>
- Date: Tue, 22 Apr 2014 16:33:37 +0100
- Subject: Re: [PATCH][RFC][wide-int] Fix some build errors on arm in wide-int branch and report ICE
- Authentication-results: sourceware.org; auth=none
- References: <534D11EB dot 9020806 at arm dot com> <53568069 dot 7010503 at arm dot com>
Kyrill Tkachov <kyrylo.tkachov@arm.com> writes:
> Ping.
> http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00769.html
> Any ideas? I recall chatter on IRC that we want to merge wide-int into trunk
> soon. Bootstrap failure on arm would prevent that...
Sorry for the late reply. I hadn't forgotten, but I wanted to wait
until I had chance to look into the ICE before replying, which I haven't
had chance to do yet.
There are still some problems on x86_64 that we need to track down.
I'm also doing one "last" read-through of the patch and I optimistically
hoped that that might find the problem you were hitting (unlikely though).
I'm not a maintainer, but the patch:
>> gcc/
>> 2014-04-15 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * wide-int.h (sign_mask): Fix syntax error.
>> * wide-int.cc (wi::add_large): Likewise.
>> (mul_internal): Likewise.
>> (sub_large): Likewise.
>>
>> c-family/
>> 2014-04-15 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * c-ada-spec.c (dump_generic_ada_node): Use HOST_WIDE_INT_PRINT
>> instead of HOST_LONG_FORMAT.
looks good to me FWIW. "Use C-style casts" might be more descriptive
than "Fix syntax error" though. It's a shame we can't use C++ style casts,
but I suppose that's the price to pay for being able to write
"unsigned HOST_WIDE_INT".
Thanks,
Richard