This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000, 4.8, 4.9, trunk] Fix little endian behavior of vec_merge[hl] for V4SI/V4SF with VSX
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 18 Apr 2014 09:16:24 -0400
- Subject: Re: [PATCH, rs6000, 4.8, 4.9, trunk] Fix little endian behavior of vec_merge[hl] for V4SI/V4SF with VSX
- Authentication-results: sourceware.org; auth=none
- References: <1397790406 dot 7170 dot 8 dot camel at gnopaine>
On Thu, Apr 17, 2014 at 11:06 PM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> I missed a case in the vector API work for little endian. When VSX is
> enabled, the vec_mergeh and vec_mergel interfaces for 4x32 vectors are
> translated into xxmrghw and xxmrglw. The patterns for these were not
> adjusted for little endian. This patch fixes this and adds tests for
> V4SI and V4SF modes when VSX is available.
>
> Bootstrapped and tested on 4.8, 4.9, and trunk for
> powerpc64le-unknown-linux-gnu with no regressions. Tests are still
> ongoing for powerpc64-unknown-linux-gnu. Provided those complete
> without regressions, is this fix ok for trunk, 4.9, and 4.8?
>
> Thanks,
> Bill
>
>
> [gcc]
>
> 2014-04-17 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * config/rs6000/vsx.md (vsx_xxmrghw_<mode>): Adjust for
> little-endian.
> (vsx_xxmrglw_<mode>): Likewise.
>
> [gcc/testsuite]
>
> 2014-04-17 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * gcc.dg/vmx/merge-vsx.c: Add V4SI and V4SF tests.
> * gcc.dg/vmx/merge-vsx-be-order.c: Likewise.
This is okay for trunk, 4.9.1 and 4.8.3. Note that the 4.9 branch is
frozen at the moment.
Thanks, David