This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Make string_view operations involving CharT* not noexcept and consistent beween string_view and string_view.tcc.

From: Jonathan Wakely <jwakely at redhat dot com>
To: Ed Smith-Rowland <3dw4rd at verizon dot net>
Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
Date: Tue, 15 Apr 2014 20:06:46 +0100
Subject: Re: Make string_view operations involving CharT* *not* noexcept and consistent beween string_view and string_view.tcc.
Authentication-results: sourceware.org; auth=none
References: <533716DC dot 10109 at verizon dot net>

On 29/03/14 14:54 -0400, Ed Smith-Rowland wrote:

All,
In string_view I botched the noexcept specification of operationslike find and friends with CharT* arguments.
I'm a little surprised the inconsistency between string_view andstring_view.tcc didn't error. In fact, in one repo thats a littlebehind trunk it does. I'll continue to look after that issueseparately.


I'm fixing this differently, by strengthening the exception specs as
Marc suggested. I haven't addressed Marc's other comments, but we
should do.

Tested x86_64-linux, committed to trunk.

Attachment: patch3.txt
Description: Text document

Follow-Ups:
- Re: Make string_view operations involving CharT* *not* noexcept and consistent beween string_view and string_view.tcc.
  - From: Ed Smith-Rowland

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Make string_view operations involving CharT* *not* noexcept and consistent beween string_view and string_view.tcc.

Re: Make string_view operations involving CharT* not noexcept and consistent beween string_view and string_view.tcc.