This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Initialize sanitizer builtins (PR sanitizer/60745)


On 04/04/14 11:14, Marek Polacek wrote:

So what happens here is that normally we initialize the builtins via
c_common_nodes_and_builtins, which has:

  5711   if (!flag_preprocess_only)
  5712     c_define_builtins (va_list_ref_type_node, va_list_arg_type_node);

c_define_builtins defines builtins in builtins.def, that includes even
sanitizer.def.  I guess that flag_preprocess_only was in effect due to PCH
and we didn't define the builtins.  I still haven't managed to create
some sweet & small testcase, but I've found another ICE with PCH:
What doesn't make sense to me is I don't see where PCH sets flag_preprocess_only. If you can point me to where that happens, then I think we'd just need a comment that PCH turns on flag_preprocess_only, which guards the creation of some builtins.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]