This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Allow VOIDmode argument to ix86_copy_addr_to_reg (PR target/60693)
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 Mar 2014 20:05:04 +0100
- Subject: Re: [PATCH] Allow VOIDmode argument to ix86_copy_addr_to_reg (PR target/60693)
- Authentication-results: sourceware.org; auth=none
- References: <20140328151934 dot GL1817 at tucnak dot redhat dot com>
On Fri, Mar 28, 2014 at 4:19 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Before ix86_copy_addr_to_reg has been added, we've been using
> copy_addr_to_reg, which handles VOIDmode values just fine.
> But this new function just ICEs on those. As the function
> has been added for adding SUBREGs to TLS addresses, those will
> never retunring CONST_INTs, so just using copy_addr_to_reg
> is IMHO the right thing and restores previous behavior.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2014-03-28 Jakub Jelinek <jakub@redhat.com>
>
> PR target/60693
> * config/i386/i386.c (ix86_copy_addr_to_reg): Call copy_addr_to_reg
> also if addr has VOIDmode.
>
> * gcc.target/i386/pr60693.c: New test.
OK.
Thanks,
Uros.