This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][ARM/AArch64][1/2] Crypto intrinsics tuning for Cortex-A53 - "type" Attribute restructuring
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: Ramana Radhakrishnan <Ramana dot Radhakrishnan at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Fri, 28 Mar 2014 17:38:30 +0000
- Subject: Re: [PATCH][ARM/AArch64][1/2] Crypto intrinsics tuning for Cortex-A53 - "type" Attribute restructuring
- Authentication-results: sourceware.org; auth=none
- References: <5331A61A dot 7080209 at arm dot com> <CAJA7tRZYSRPCRPFJQB+EfSAjxX59dL11TnVSMLO+ntPCF4NWSQ at mail dot gmail dot com> <5335AEE3 dot 40906 at arm dot com>
- Reply-to: ramrad01 at arm dot com
On Fri, Mar 28, 2014 at 5:18 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
> On 28/03/14 14:18, Ramana Radhakrishnan wrote:
>>
>> On Tue, Mar 25, 2014 at 3:51 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com>
>> wrote:
>>>
>>> Hi all,
>>>
>>> This two-patch series adds scheduling information for the ARMv8-A Crypto
>>> instructions on the Cortex-A53.
>>> This first patch does some preliminary restructuring to allow the arm and
>>> aarch64 backends to share the is_neon_type attribute.
>>>
>>> It also splits the crypto_aes type into crypto_aese and crypto_aesmc
>>> since
>>> the aese/aesd and aesmc/aesimc instructions will be treated differently
>>> (in
>>> patch 2/2).
>>>
>>> This patch touches both arm and aarch64 backends since there's no clean
>>> way
>>> to split it into per-backend patches without breaking each one.
>>>
>>> Tested and bootstrapped on arm-none-linux-gnueabihf and on
>>> aarch64-none-linux-gnu.
>>>
>>> This patch is fairly uncontroversial and doesn't change functionality or
>>> code generation by itself.
>>>
>>> I'll leave it to the maintainers to decide when this should go in...
>>
>> The real question is about patch #2. So this going in just depends on
>> patch #2.
>
>
> #2 has been ok'd. Can I take this as an approval for this patch?
Yes -
Ramana
>
> Kyrill
>
>
>>
>>
>> Ramana
>>
>>> Thanks,
>>> Kyrill
>>>
>>> 2014-03-25 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>>
>>> * config/aarch64/aarch64-simd.md (aarch64_crypto_aes<aes_op>v16qi):
>>> Use crypto_aese type.
>>> (aarch64_crypto_aes<aesmc_op>v16qi): Use crypto_aesmc type.
>>> * config/arm/arm.md (is_neon_type): Replace crypto_aes with
>>> crypto_aese, crypto_aesmc. Move to types.md.
>>> * config/arm/types.md (crypto_aes): Split into crypto_aese,
>>> crypto_aesmc.
>>> * config/arm/iterators.md (crypto_type): Likewise.
>
>
>