This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Rüdiger Sonderfeld <ruediger at c-plusplus dot de>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Mar 2014 16:27:14 +0000
- Subject: Re: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.
- Authentication-results: sourceware.org; auth=none
- References: <20140327133723 dot GA13599 at redhat dot com> <1901588 dot qodTErPe42 at descartes>
On 27/03/14 17:00 +0100, Rüdiger Sonderfeld wrote:
Hello Jonathan,
thanks for your comments.
N.B. patches to the ChangeLog rarely apply cleanly (because someone
else may have changed the ChangeLog since the patch was created) so
the convention is to send the ChangeLog entry in the email body, or as
a separate attachment, or by using 'git log -p @{u}..' so the commit
log shows it, rather than as part of the patch.
Yes, ChangeLog's can be a bit of a pain. I removed the ChangeLog from the
patch. But FYI there is a ChangeLog merge driver hidden in gnulib, which
can be helpful when dealing with ChangeLog files in git (and potentially
other version control systems)
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/git-merge-changelog.c
Yes, I use that myself, and generate patches with the 'git lgp'
command shown at http://gcc.gnu.org/wiki/GitMirror
We could document that (fixed|scientific) has that effect in c++98
mode.
Where should it be documented?
Probably somewhere in doc/xml/manual/io.xml but I'm happy to do that
once the patch is committed if you like.
Thanks for the updated patch, I will try to remember to commit it when
stage 1 starts. If you don't get a mail from me then please ping me as
a reminder.