This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.
- From: Rüdiger Sonderfeld <ruediger at c-plusplus dot de>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Mar 2014 17:00:19 +0100
- Subject: [PATCH v2] libstdc++: Add hexfloat/defaultfloat io manipulators.
- Authentication-results: sourceware.org; auth=none
- References: <20140327133723 dot GA13599 at redhat dot com>
Hello Jonathan,
thanks for your comments.
> N.B. patches to the ChangeLog rarely apply cleanly (because someone
> else may have changed the ChangeLog since the patch was created) so
> the convention is to send the ChangeLog entry in the email body, or as
> a separate attachment, or by using 'git log -p @{u}..' so the commit
> log shows it, rather than as part of the patch.
Yes, ChangeLog's can be a bit of a pain. I removed the ChangeLog from the
patch. But FYI there is a ChangeLog merge driver hidden in gnulib, which
can be helpful when dealing with ChangeLog files in git (and potentially
other version control systems)
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=lib/git-merge-changelog.c
> We could document that (fixed|scientific) has that effect in c++98
> mode.
Where should it be documented?
Regards,
RÃdiger
-- 8< ---------------------------------------------------------- >8 --
* include/bits/ios_base.h (hexfloat): New function.
(defaultfloat): New function.
* src/c++98/locale_facets.cc (__num_base::_S_format_float):
Support hexadecimal floating point format.
* testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc:
New file.
Signed-off-by: RÃdiger Sonderfeld <ruediger@c-plusplus.de>
---
libstdc++-v3/include/bits/ios_base.h | 21 +++
libstdc++-v3/src/c++98/locale_facets.cc | 4 +
.../inserters_arithmetic/char/hexfloat.cc | 141 +++++++++++++++++++++
3 files changed, 166 insertions(+)
create mode 100644 libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc
diff --git a/libstdc++-v3/include/bits/ios_base.h b/libstdc++-v3/include/bits/ios_base.h
index ae856de..b7fae43 100644
--- a/libstdc++-v3/include/bits/ios_base.h
+++ b/libstdc++-v3/include/bits/ios_base.h
@@ -969,6 +969,27 @@ namespace std _GLIBCXX_VISIBILITY(default)
return __base;
}
+#if __cplusplus >= 201103L
+ // New C++11 floatfield manipulators
+
+ /// Calls base.setf(ios_base::fixed | ios_base::scientific,
+ /// ios_base::floatfield).
+ inline ios_base&
+ hexfloat(ios_base& __base)
+ {
+ __base.setf(ios_base::fixed | ios_base::scientific, ios_base::floatfield);
+ return __base;
+ }
+
+ /// Calls base.unsetf(ios_base::floatfield).
+ inline ios_base&
+ defaultfloat(ios_base& __base)
+ {
+ __base.unsetf(ios_base::floatfield);
+ return __base;
+ }
+#endif // __cplusplus >= 201103L
+
_GLIBCXX_END_NAMESPACE_VERSION
} // namespace
diff --git a/libstdc++-v3/src/c++98/locale_facets.cc b/libstdc++-v3/src/c++98/locale_facets.cc
index 3669acb..a21d665 100644
--- a/libstdc++-v3/src/c++98/locale_facets.cc
+++ b/libstdc++-v3/src/c++98/locale_facets.cc
@@ -82,6 +82,10 @@ namespace std _GLIBCXX_VISIBILITY(default)
*__fptr++ = 'f';
else if (__fltfield == ios_base::scientific)
*__fptr++ = (__flags & ios_base::uppercase) ? 'E' : 'e';
+#ifdef _GLIBCXX_USE_C99
+ else if (__fltfield == (ios_base::fixed | ios_base::scientific))
+ *__fptr++ = (__flags & ios_base::uppercase) ? 'A' : 'a';
+#endif
else
*__fptr++ = (__flags & ios_base::uppercase) ? 'G' : 'g';
*__fptr = '\0';
diff --git a/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc
new file mode 100644
index 0000000..55c46ad
--- /dev/null
+++ b/libstdc++-v3/testsuite/27_io/basic_ostream/inserters_arithmetic/char/hexfloat.cc
@@ -0,0 +1,141 @@
+// { dg-options "-std=gnu++11" }
+
+// 2014-03-27 RÃdiger Sonderfeld
+// test the hexadecimal floating point inserters (facet num_put)
+
+// Copyright (C) 2014 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library. This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#include <iostream>
+#include <iomanip>
+#include <sstream>
+#include <limits>
+#include <testsuite_hooks.h>
+
+using namespace std;
+
+#ifndef _GLIBCXX_ASSERT
+# define TEST_NUMPUT_VERBOSE 1
+#endif
+
+void
+test01()
+{
+ {
+ ostringstream os;
+ double d = 272.; // 0x1.1p+8;
+ cout << os.precision() << endl;
+ os << hexfloat << setprecision(1);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0x1.1p+8" );
+ os.str("");
+ os << uppercase << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0X1.1P+8" );
+ os << nouppercase;
+ os.str("");
+ os << defaultfloat << setprecision(6);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "272" );
+
+ os.str("");
+ d = 15.; //0x1.ep+3;
+ os << hexfloat << setprecision(1);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0x1.ep+3" );
+ os.str("");
+ os << uppercase << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0X1.EP+3" );
+ os << nouppercase;
+ os.str("");
+ os << defaultfloat << setprecision(6);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "15" );
+ }
+
+ {
+ ostringstream os;
+ long double d = 272.L; // 0x1.1p+8L;
+ os << hexfloat << setprecision(1);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0x8.8p+5" );
+ os.str("");
+ os << uppercase << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0X8.8P+5" );
+ os << nouppercase;
+ os.str("");
+ os << defaultfloat << setprecision(6);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "272" );
+
+ os.str("");
+ os << hexfloat << setprecision(1);
+ d = 15.; //0x1.ep+3;
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0xf.0p+0" );
+ os.str("");
+ os << uppercase << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "0XF.0P+0" );
+ os << nouppercase;
+ os.str("");
+ os << defaultfloat << setprecision(6);
+ os << d;
+#ifdef TEST_NUMPUT_VERBOSE
+ cout << "got: " << os.str() << endl;
+#endif
+ VERIFY( os && os.str() == "15" );
+ }
+}
+
+int
+main()
+{
+ test01();
+ return 0;
+}
--
1.9.1