This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [GOOGLE] Refactor the LIPO fixup
- From: Xinliang David Li <davidxl at google dot com>
- To: Dehao Chen <dehao at google dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Rong Xu <xur at google dot com>
- Date: Wed, 26 Mar 2014 16:05:27 -0700
- Subject: Re: [GOOGLE] Refactor the LIPO fixup
- Authentication-results: sourceware.org; auth=none
- References: <CAO2gOZXE+jF23DvJWw3+_UkYgZZ=OZWebA9VhR8u_Sp8dF+bJw at mail dot gmail dot com> <CAAkRFZLpUdaBCRS3K7PS2bxjLn+8hf9R8J0cgxmQhHX9eizvew at mail dot gmail dot com> <CAO2gOZUEG=Zo0znpWoKRXhGJf4F-E_YmvoHTuRk1wS7+WqK-NA at mail dot gmail dot com>
is cgraph_init_gid_map called after linking?
David
On Wed, Mar 26, 2014 at 3:54 PM, Dehao Chen <dehao@google.com> wrote:
> Patch updated, passed performance tests.
>
> Dehao
>
> On Tue, Mar 25, 2014 at 4:03 PM, Xinliang David Li <davidxl@google.com> wrote:
>> Add comment to the new function. init_node_map is better invoked after
>> the link step to avoid creating entries with for dead nodes.
>>
>> Ok if large perf testing is fine.
>>
>> David
>>
>> On Tue, Mar 25, 2014 at 3:38 PM, Dehao Chen <dehao@google.com> wrote:
>>> This patch refactors LIPO fixup related code to move it into a
>>> standalone function. This makes sure that
>>> symtab_remove_unreachable_nodes is called right after the fixup so
>>> that there is not dangling cgraph nodes any time.
>>>
>>> Bootstrapped and regression test on-going.
>>>
>>> OK for google-4_8?
>>>
>>> Thanks,
>>> Dehao