This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Warn if inline attributes conflict (PR c/18079)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 20 Mar 2014 15:24:37 +0000
- Subject: Re: [C PATCH] Warn if inline attributes conflict (PR c/18079)
- Authentication-results: sourceware.org; auth=none
- References: <20140320110736 dot GL6523 at redhat dot com> <CAFiYyc2jRHS+B8veVeJOOZ6eTAbw=jap4oEtOJ0=Fq=ht54Epw at mail dot gmail dot com> <20140320114552 dot GM6523 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1403201153450 dot 24827 at digraph dot polyomino dot org dot uk> <20140320144423 dot GN6523 at redhat dot com>
On Thu, 20 Mar 2014, Marek Polacek wrote:
> On Thu, Mar 20, 2014 at 11:57:57AM +0000, Joseph S. Myers wrote:
> > This version is OK (for after 4.9 branches).
>
> Thanks.
>
> > What happens if there are two declarations of the function, one with each
> > attribute? The testcase doesn't cover that.
>
> Nothing :(. I had to add some code into diagnose_mismatched_decls to
> detect such conflicting decls (plus for cold/hot; there may be others).
>
> Tested x86_64-linux. Is this version ok?
Yes.
--
Joseph S. Myers
joseph@codesourcery.com