This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch testsuite]: Fix some mingw testcases in gcc.dg
- From: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- To: Kai Tietz <ktietz70 at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 17 Mar 2014 22:27:37 +0100
- Subject: Re: [patch testsuite]: Fix some mingw testcases in gcc.dg
- Authentication-results: sourceware.org; auth=none
- References: <CAEwic4bPWvDS6rs8gVoxFGo-UwKv8-p75+erHy3d+SFa-sbYQg at mail dot gmail dot com> <yddiorch7n2 dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <CAEwic4ap6T6XkC=ycnbHNG3RT3xJ366ozBb+XXXZDZT6656R=g at mail dot gmail dot com>
Kai Tietz <ktietz70@googlemail.com> writes:
> 2014-03-17 21:50 GMT+01:00 Rainer Orth <ro@cebitec.uni-bielefeld.de>:
>> Hi Kai,
>>
>>> this patch fixes some regressions introduced by default-option
>>> -fms-extensions for mingw-targets.
>>
>> you should state in your submissions *which* regressions were
>> introduced/*which* problem you are fixing. While this may be obvious to
>> you, it's often not so to reviewers.
>
> I did. "The regressions in testsuite are introduced by turning on the
> state of -fms-extensions." That all, and not more to tell.
You didn't. *Which* regressions? What happens? I had to infer it from
a comment in one of the changed testcases:
/* In strict ISO C mode, we don't recognize the anonymous struct/union
extension or any Microsoft extensions. */
If you'd cited the compiler error you get for one of the testcases,
everything had been clear.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University