This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH][AARCH64]Amend AArch64 frame layout comment.


Hi all,

This is a simple patch to update the AArch64 frame layout comment in the source code. frame_pointer should point above the local_variables section as we define FRAME_GROWS_DOWNWARD = 1.

Is this Okay for stage-4?

Regards,
Renlin Li


gcc/ChangeLog:

2014-03-16  Renlin Li  <Renlin.Li@arm.com>

* config/aarch64/aarch64.c: Correct the comments about aarch64 stack layout.
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 901ad3d..fe96a28 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -1994,18 +1994,21 @@ aarch64_save_or_restore_callee_save_registers (HOST_WIDE_INT offset,
 	|  callee-allocated save area   |
 	|  for register varargs         |
 	|                               |
-	+-------------------------------+
-	|                               |
-	|  local variables              |
-	|                               |
 	+-------------------------------+ <-- frame_pointer_rtx
 	|                               |
-	|  callee-saved registers       |
+	|  local variables              |
 	|                               |
-	+-------------------------------+
-	|  LR'                          |
-	+-------------------------------+
-	|  FP'                          |
+	+-------------------------------+
+	|  padding0                     | \
+	+-------------------------------+  |
+	|                               |  |
+	|                               |  |
+	|  callee-saved registers       |  | frame.saved_regs_size
+	|                               |  |
+	+-------------------------------+  |
+	|  LR'                          |  |
+	+-------------------------------+  |
+	|  FP'                          | /
       P +-------------------------------+ <-- hard_frame_pointer_rtx
 	|  dynamic allocation           |
 	+-------------------------------+

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]