This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix error message from -Wcast-qual when casting away volatile
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Gerald Pfeifer <gerald at pfeifer dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Joseph Myers <joseph at codesourcery dot com>, Magnus Reftel <magnus dot reftel at gmail dot com>
- Date: Tue, 11 Mar 2014 17:12:25 +0100
- Subject: Re: [PATCH] Fix error message from -Wcast-qual when casting away volatile
- Authentication-results: sourceware.org; auth=none
- References: <CABqVM5Fb3qjj2iMWdvV+LQiJtGbam+LQToukwXCQV=dy613mtw at mail dot gmail dot com> <alpine dot LSU dot 2 dot 11 dot 1403111706350 dot 7314 at tuna dot site>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Mar 11, 2014 at 05:10:45PM +0100, Gerald Pfeifer wrote:
> On Tue, 11 Mar 2014, Magnus Reftel wrote:
> > Currently, castring away volatile from a pointer makes -Wcast-qual
> > claim that __attribute__((noreturn)) was cast away (see bugzilla
> > 55383). The attached patch, originally written by Manuel López-Ibáñez
> > and updated to match trunk by me, correctes that. No regressions on
> > gcc from applying this patch (as reported by "make check") were seen.
> >
> > 2014-03-11 Manuel López-Ibáñez <manu@gcc.gnu.org>
> >
> > PR c/55383
> > * c/c-typeck.c: use correct format string in cast-qual warning
>
> I volunteer applying this if approved.
The ChangeLog is incorrect (there should be two spaces before Manuel and
no c/ prefix for the filename).
I'll defer review to Joseph or Jason.
Jakub