This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/4] [GOMP4] [Fortran] OpenACC 1.0+ support in fortran front-end
- From: Ilmir Usmanov <i dot usmanov at samsung dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, Evgeny Gavrin <e dot gavrin at samsung dot com>, GarbuzovViacheslav <v dot garbuzov at samsung dot com>, Dmitri Botcharnikov <dmitry dot b at samsung dot com>, gcc-patches at gcc dot gnu dot org, jakub at redhat dot com, fortran at gcc dot gnu dot org
- Date: Fri, 07 Mar 2014 14:44:25 +0400
- Subject: Re: [PATCH 1/4] [GOMP4] [Fortran] OpenACC 1.0+ support in fortran front-end
- Authentication-results: sourceware.org; auth=none
- References: <52E158EF dot 9050009 at samsung dot com> <877g9pqmt2 dot fsf at schwinge dot name> <52E65B24 dot 9070403 at samsung dot com> <87iot5pgqb dot fsf at schwinge dot name> <52EB8437 dot 3060602 at samsung dot com> <52EB84C3 dot 4010407 at samsung dot com> <52F7FFAA dot 9020702 at net-b dot de> <5304CEFC dot 4000602 at samsung dot com> <53054370 dot 2030802 at net-b dot de> <5305BA82 dot 5060804 at samsung dot com> <53158715 dot 1090908 at samsung dot com> <5315873E dot 4010203 at samsung dot com> <53160B41 dot 3060501 at net-b dot de>
Hi Tobias!
Thanks a lot for your review!
!$acc loop
outer_loop: do i = 1, n
inner_loop: do j = 1,m
! ...
cycle outer_loop
exit outer_loop
end do inner_loop
end do outer_loop
That's a new Fortran 2008 feature that CYCLE and EXIT can leave the
inner DO loop.
I added the following to test suite:
!$acc loop
outer_loop: do i = 1, 5
inner_loop: do j = 1,5
if (i .eq. j) cycle outer_loop
if (i .ne. j) exit outer_loop ! { dg-error "EXIT statement" }
end do inner_loop
end do outer_loop
outer_loop1: do i = 1, 5
!$acc loop
inner_loop1: do j = 1,5
if (i .eq. j) cycle outer_loop1 ! { dg-error "CYCLE statement" }
end do inner_loop1
end do outer_loop1
!$acc loop collapse(2)
outer_loop2: do i = 1, 5
inner_loop2: do j = 1,5
if (i .eq. j) cycle outer_loop2 ! { dg-error "CYCLE statement" }
if (i .ne. j) exit outer_loop2 ! { dg-error "EXIT statement" }
end do inner_loop2
end do outer_loop2
All cases pass.
The second one passes due to check of structured blocks:
if (o != NULL)
{
gfc_error ("%s statement at %C leaving OpenMP structured block",
gfc_ascii_statement (st));
return MATCH_ERROR;
}
So, I needed to change error message.
Also I fixed checks of polymofphic type and indentation.
OK for gomp4 branch?
--
Ilmir.