This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Install config/i386/stringop.def as a plugin header
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 5 Mar 2014 10:25:45 +0100
- Subject: Re: [PATCH] Install config/i386/stringop.def as a plugin header
- Authentication-results: sourceware.org; auth=none
- References: <20140305084825 dot GU22862 at tucnak dot redhat dot com> <CAFULd4YABp-xT=JxvZtKoPpqj=5LzcxzA=i+mw9EjSBUJM77pw at mail dot gmail dot com> <20140305092045 dot GW22862 at tucnak dot redhat dot com>
On Wed, Mar 5, 2014 at 10:20 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>> > Pretty much all plugins fail to compile against installed plugin headers
>> > on i?86, because stringop.def isn't installed.
>> >
>> > This patch should fix that, ok if testing succeeds?
>> >
>> > 2014-03-05 Jakub Jelinek <jakub@redhat.com>
>> >
>> > * config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def.
>>
>> This is actually PR59335 [1], and as shown there, a couple of other
>> headers are missing as well.
>>
>> [1] http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59335
>
> Ah, I see, not sure we have to handle everything at once though, it can be
> fixed incrementally.
> Anyway, as for OPTIONS_H_EXTRA vs. PLUGIN_HEADERS, I think the former is
> more correct, stringop.def is included by i386-opts.h.
> And x86-tune.def, being included directly by i386.h, should be added to
> TM_H.
> So is this ok instead?
>
> Note, only tested with make install and checking that the *.def file is
> installed.
>
> 2014-03-05 Jakub Jelinek <jakub@redhat.com>
>
> PR plugins/59335
> * config/i386/t-i386 (OPTIONS_H_EXTRA): Add stringop.def.
OK with updated ChangeLog.
Thanks,
Uros.