This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ping] Re: [PATCH, AARCH64] MULTIARCH_DIRNAME breaks multiarch build

From: Richard Earnshaw <rearnsha at arm dot com>
To: Matthias Klose <doko at ubuntu dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Cc: Zhenqiang Chen <zhenqiang dot chen at linaro dot org>, Yufeng Zhang <Yufeng dot Zhang at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Paolo Bonzini <bonzini at gnu dot org>, "dj at redhat dot com" <dj at redhat dot com>, "neroden at gcc dot gnu dot org" <neroden at gcc dot gnu dot org>, Alexandre Oliva <aoliva at redhat dot com>, Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
Date: Wed, 05 Mar 2014 08:12:58 +0000
Subject: Re: [ping] Re: [PATCH, AARCH64] MULTIARCH_DIRNAME breaks multiarch build
Authentication-results: sourceware.org; auth=none
References: <CACgzC7Cv4=ZYh=fc9xGbabdyYGWfGqET2QAr8q0j7CERkhEv0A at mail dot gmail dot com> <52CFBC2F dot 9040004 at ubuntu dot com> <CACgzC7CDT=J48Bc1RNvkL5X0CGgpaaVE90sSSS_3mjcGxAidfw at mail dot gmail dot com> <52CFD42A dot 7030305 at ubuntu dot com> <52EB9926 dot 1060800 at ubuntu dot com>

On 31/01/14 12:37, Matthias Klose wrote:

ping, adding build maintainers

I was hoping one of the configury maintainers would comment on this. Nosuch luck.


Based on the following in the manual:

"@code{MULTIARCH_DIRNAME} is not used for configurations that support
both multilib and multiarch.  In that case, multiarch names are encoded
in @code{MULTILIB_OSDIRNAMES} instead."

I think this is OK.

Please give the configury maintainers 24 hours to comment before committing.

R.

Am 10.01.2014 12:06, schrieb Matthias Klose:

Am 10.01.2014 10:49, schrieb Zhenqiang Chen:

On 10 January 2014 17:23, Matthias Klose <doko@ubuntu.com> wrote:

Am 10.01.2014 09:23, schrieb Zhenqiang Chen:

Hi,

MULTIARCH_DIRNAME was removed @r196649 since the dir info had been
combined in MULTILIB_OSDIRNAMES.

But MULTIARCH_DIRNAME was re-added @r201164. With this change, the
final multiarch_dir is combined as
"aarch64-linux-gnu:aarch64-linux-gnu", which is incorrect and leads to
multiarch build fail if the sysroot is in correct multiarch layout.

Any reason to add MULTIARCH_DIRNAME? If it is not necessary, can we
remove it as the patch?


see the thread "[patch] set MULTIARCH_DIRNAME for multilib architectures" from
June 2013.  I think it is necessary to have the default defined.  Yesterday's
build looks ok for me, looking at default and include paths, so maybe I don't
yet understand the issue.


In our build, we configure eglbc with
rtlddir=/lib
libdir=/usr/lib/aarch64-linux-gnu
slibdir=/lib/aarch64-linux-gnu

And we configure gcc with "--disable-multilib --enable-multiarch",
But when building gcc libraries, configure FAIL since it can not find
the C libraries. And I try
./xgcc --print-multiarch
the output is "aarch64-linux-gnu:aarch64-linux-gnu"

Any comments?


Thanks!
-Zhenqiang

I think aarch64 is the only architecture which introduces MULTILIB_* macros
without actually building any multilib, just to set the default library name to
lib64. So maybe this has some side effects.


sorry, I have a local patch applied after the lib64 change, which I forgot to
forward.

	* Makefile.in (s-mlib): Only pass MULTIARCH_DIRNAME if
	MULTILIB_OSDIRNAMES is not defined.

--- a/src/gcc/Makefile.in
+++ b/src/gcc/Makefile.in
@@ -1837,7 +1837,7 @@
             "$(MULTILIB_EXCLUSIONS)" \
             "$(MULTILIB_OSDIRNAMES)" \
             "$(MULTILIB_REQUIRED)" \
-           "$(MULTIARCH_DIRNAME)" \
+           "$(if $(MULTILIB_OSDIRNAMES),,$(MULTIARCH_DIRNAME))" \
             "$(MULTILIB_REUSE)" \
             "@enable_multilib@" \
             > tmp-mlib.h; \

applied/tested since July 2013 on the Debian/Ubuntu distro builds. It doesn't
affect the non-multiarch case.

Ok for the trunk?

   Matthias

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]