This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Mircea Namolaru <mircea dot namolaru at inria dot fr>
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>, Tobias Grosser <tobias at grosser dot es>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 3 Mar 2014 12:39:23 +0100
- Subject: Re: [PATCH,GRAPHITE] Fix for P1 bug 58028
- Authentication-results: sourceware.org; auth=none
- References: <20140227094159 dot GA13605 at physik dot fu-berlin dot de> <yddy50w3lrt dot fsf at lokon dot CeBiTec dot Uni-Bielefeld dot DE> <1739186346 dot 4998092 dot 1393536655802 dot JavaMail dot zimbra at inria dot fr> <ydd61o0p537 dot fsf at CeBiTec dot Uni-Bielefeld dot DE> <645960637 dot 5604340 dot 1393616238164 dot JavaMail dot zimbra at inria dot fr>
On Fri, Feb 28, 2014 at 8:37 PM, Mircea Namolaru
<mircea.namolaru@inria.fr> wrote:
> Hi,
>
> Thanks. Here is the updated patch.
Boostrapped / tested on x86_64-unknown-linux-gnu and applied.
Thanks,
Richard.
> 2014-02-26 Tobias Grosser <tobias@grosser.es>
> Mircea Namolaru <mircea.namolaru@inria.fr>
>
> PR tree-optimization/58028
> * graphite-clast-to-gimple.c (set_cloog_options): Don't remove scalar
> dimensions.
>
> Index: gcc/graphite-clast-to-gimple.c
> ===================================================================
> --- gcc/graphite-clast-to-gimple.c (revision 207298)
> +++ gcc/graphite-clast-to-gimple.c (working copy)
> @@ -1522,6 +1522,13 @@
> variables. */
> options->save_domains = 1;
>
> + /* Do not remove scalar dimensions. CLooG by default removes scalar
> + dimensions very early from the input schedule. However, they are
> + necessary to correctly derive from the saved domains
> + (options->save_domains) the relationship between the generated loops
> + and the schedule dimensions they are generated from. */
> + options->noscalars = 1;
> +
> /* Disable optimizations and make cloog generate source code closer to the
> input. This is useful for debugging, but later we want the optimized
> code.
>
> Mircea